-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to point to datafusion.apache.org #10195
Conversation
- [Project Site](https://datafusion.apache.org/) | ||
- [Installation](https://datafusion.apache.org/user-guide/cli/installation.html) | ||
- [Rust Getting Started](https://datafusion.apache.org/user-guide/example-usage.html) | ||
- [Rust DataFrame API](https://datafusion.apache.org/user-guide/dataframe.html) | ||
- [Rust API docs](https://docs.rs/datafusion/latest/datafusion) | ||
- [Rust Examples](https://github.com/apache/datafusion/tree/master/datafusion-examples) | ||
- [Python DataFrame API](https://arrow.apache.org/datafusion-python/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should the new URL be for https://arrow.apache.org/datafusion-python/ ? I'm thinking https://datafusion.apache.org/python. That change will need to be made in https://github.com/apache/datafusion-python first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will also need a redirect link similar to apache/arrow-site#502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related change to datafusion-python: apache/datafusion-python#643
@@ -463,7 +463,7 @@ svn delete -m "delete old DataFusion release" https://dist.apache.org/repos/dist | |||
- Checkout the `asf-site` branch | |||
- Copy content from `docs/build/html/*` to the `datafusion` directory in arrow-site | |||
- Create a PR against the `asf-site` branch ([example](https://github.com/apache/arrow-site/pull/237)) | |||
- Once the PR is merged, the content will be published to https://arrow.apache.org/datafusion/ by GitHub Pages (this | |||
- Once the PR is merged, the content will be published to https://datafusion.apache.org/ by GitHub Pages (this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section seems outdated? I can remove it if so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree this entire section (### Publish the User Guide to the Arrow Site
) is outdated -- let's delete it as a follow on PR (no need to do it as part of this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it -- thank you @phillipleblanc for keeping the migration 🚋 rolling 🚀
@@ -463,7 +463,7 @@ svn delete -m "delete old DataFusion release" https://dist.apache.org/repos/dist | |||
- Checkout the `asf-site` branch | |||
- Copy content from `docs/build/html/*` to the `datafusion` directory in arrow-site | |||
- Create a PR against the `asf-site` branch ([example](https://github.com/apache/arrow-site/pull/237)) | |||
- Once the PR is merged, the content will be published to https://arrow.apache.org/datafusion/ by GitHub Pages (this | |||
- Once the PR is merged, the content will be published to https://datafusion.apache.org/ by GitHub Pages (this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree this entire section (### Publish the User Guide to the Arrow Site
) is outdated -- let's delete it as a follow on PR (no need to do it as part of this PR)
Which issue does this PR close?
Part of #9691
Rationale for this change
Updates the links in the repo to point to https://datafusion.apache.org instead of https://arrow.apache.org/datafusion
What changes are included in this PR?
Are these changes tested?
I clicked through each link as I made the change.
Are there any user-facing changes?